Skip to content

ci: Remove setup_cache.sh#30261

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:no-setup-cache
Oct 20, 2023
Merged

ci: Remove setup_cache.sh#30261
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:no-setup-cache

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Oct 17, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft October 17, 2023 10:38
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 17, 2023

@wbpcode as discussed on previous pr this removes setup_cache.sh altogether

my hesitance to remove it previously was due to the fact that its currently hooked up to both the dev container and in mac/windows ci - so i need to check in each case that nothing is broken etc

@phlax phlax force-pushed the no-setup-cache branch 8 times, most recently from 51c07f8 to 7f38c48 Compare October 19, 2023 11:25
@phlax phlax changed the title [WIP] ci: Remove setup_cache.sh ci: Remove setup_cache.sh Oct 19, 2023
@phlax phlax marked this pull request as ready for review October 19, 2023 13:46
Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax merged commit 0ccf481 into envoyproxy:main Oct 20, 2023
phlax added a commit to phlax/envoy that referenced this pull request Oct 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Oct 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Oct 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Oct 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Oct 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this pull request Apr 3, 2024
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants